Fix address sanitizer warnings with stencil table casting #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility, StencilTableReal<float> is cast to StencilTable, which has the same data layout but it's not actually an instance of that class. And so using static_cast is not strictly correct. Use reinterpret_cast instead.
|
Hi Brecht! Would you mind submitting an OpenSubdiv CLA which is distinct from the OpenUSD CLA we already have on file. Thanks! |
|
Ah, I didn't realize. Sent now. |
|
Filed as internal issue #OSD-451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility,
StencilTableReal<float>is cast toStencilTable, which has the same data layout but it's not actually an instance of that class. And so usingstatic_castis not strictly correct. Usereinterpret_castinstead.