Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing libpng and libz for rendering bitmap glyphs #134

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

narodnik
Copy link

Fixes #133

@bvssvni
Copy link
Member

bvssvni commented Jul 8, 2024

@narodnik Can you rebase?

@narodnik
Copy link
Author

ok I found it easier to redo the entire commit. Plz pull it now so I don't have to do this all over again

@bvssvni
Copy link
Member

bvssvni commented Oct 5, 2024

@narodnik some of the checks are failing.

@narodnik
Copy link
Author

The windows build works but is failing during the test because it isn't recursively checking out the submodule properly.

libz-sys contains a submodule in src/zlib to another submodule for zlib, which includes the zlib.h:

    build.include("libpng").include("libz-sys/src/zlib");

So this is an error with the CI build system, rather than the code.

@bvssvni
Copy link
Member

bvssvni commented Oct 20, 2024

Merging.

@bvssvni bvssvni merged commit 45068f7 into PistonDevelopers:master Oct 20, 2024
3 of 4 checks passed
@bvssvni
Copy link
Member

bvssvni commented Oct 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freetype doesnt load bitmap emojis
2 participants