Linear - pin sdk version #17975
Linear - pin sdk version #17975
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThis update consists entirely of version number increments across multiple action and source components within the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
components/linear_app/actions/create-issue/create-issue.mjs(1 hunks)components/linear_app/actions/get-issue/get-issue.mjs(1 hunks)components/linear_app/actions/get-teams/get-teams.mjs(1 hunks)components/linear_app/actions/search-issues/search-issues.mjs(1 hunks)components/linear_app/actions/update-issue/update-issue.mjs(1 hunks)components/linear_app/linear_app.app.mjs(1 hunks)components/linear_app/package.json(1 hunks)components/linear_app/sources/comment-created-instant/comment-created-instant.mjs(1 hunks)components/linear_app/sources/issue-created-instant/issue-created-instant.mjs(1 hunks)components/linear_app/sources/issue-updated-instant/issue-updated-instant.mjs(1 hunks)components/linear_app/sources/new-issue-status-updated/new-issue-status-updated.mjs(1 hunks)components/linear_app/sources/new-projectupdate-created/new-projectupdate-created.mjs(1 hunks)components/linear_app/sources/project-updated-instant/project-updated-instant.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/linear_app/package.json
📚 Learning: 2025-01-23T03:55:15.166Z
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Applied to files:
components/linear_app/sources/project-updated-instant/project-updated-instant.mjscomponents/linear_app/sources/new-projectupdate-created/new-projectupdate-created.mjs
📚 Learning: 2024-10-30T15:24:39.294Z
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Applied to files:
components/linear_app/actions/create-issue/create-issue.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
🔇 Additional comments (12)
components/linear_app/package.json (1)
3-3: Patch version bump looks good – double-check SDK pinning consistencyThe project version increment to
0.7.4is fine.
However, the code now imports@linear/sdk@13.0.0directly (seelinear_app.app.mjsLine 1) while the dependency spec here is"@linear/sdk": "^13.0.0". If caret-range upgrades pull in13.x.y > 0, the runtime will still resolve@linear/sdk, not@linear/sdk@13.x.y, and the two specifiers will be treated as different packages. This can yield duplicate copies of the SDK or a hard-to-debug “module not found” error.‣ Either:
- Revert the code import to
@linear/sdk, or- Pin the dependency to the exact version
13.0.0so both specifiers resolve identically.Please verify which approach is required in the Pipedream runtime.
components/linear_app/actions/update-issue/update-issue.mjs (1)
8-8: Version bump acknowledgedPatch version
0.1.11recorded — no logic changes. 👍components/linear_app/actions/search-issues/search-issues.mjs (1)
10-10: Version bump acknowledgedPatch version
0.2.11recorded — no logic changes. 👍components/linear_app/actions/create-issue/create-issue.mjs (1)
8-8: Version bump acknowledgedPatch version
0.4.11recorded — no logic changes. 👍components/linear_app/actions/get-teams/get-teams.mjs (1)
8-8: Patch-level version bump looks goodNo functional code changed—only the metadata.
components/linear_app/actions/get-issue/get-issue.mjs (1)
7-7: Version increment acknowledgedPatch release is consistent with the rest of the Linear actions.
components/linear_app/sources/project-updated-instant/project-updated-instant.mjs (1)
11-11: Source version bumped—LGTMNo logic touched; change aligns with coordinated release.
components/linear_app/sources/new-projectupdate-created/new-projectupdate-created.mjs (1)
11-11: Minor version bump verifiedMetadata only; nothing else to review.
components/linear_app/sources/new-issue-status-updated/new-issue-status-updated.mjs (1)
11-11: Patch version update acceptedConsistent with other source updates; no further action required.
components/linear_app/sources/issue-created-instant/issue-created-instant.mjs (1)
10-10: Version bump looks goodPatch-level increment to
0.3.13is consistent with the rest of the Linear sources/actions in this PR. No functional impact detected.components/linear_app/sources/comment-created-instant/comment-created-instant.mjs (1)
10-10: Version updated correctlyIncrementing to
0.1.13keeps the component in sync with the overall package version bump; nothing else changed.components/linear_app/sources/issue-updated-instant/issue-updated-instant.mjs (1)
10-10: Patch version increment approved
versionfield moved to0.3.13, matching the coordinated release set. No further comments.
| @@ -1,4 +1,4 @@ | |||
| import { LinearClient } from "@linear/sdk"; | |||
| import { LinearClient } from "@linear/sdk@13.0.0"; | |||
There was a problem hiding this comment.
@linear/sdk@13.0.0 import is very likely invalid in Node/Pipedream
Bare Node’s module resolver (and most bundlers) treat the entire string @linear/sdk@13.0.0 as the package name, so it will look for a folder literally named node_modules/@linear/sdk@13.0.0, which is not installed. This will throw at load time.
Unless the Pipedream runtime provides custom “package@version” resolution (not documented), please revert to the normal import and rely on package.json to lock the version:
-import { LinearClient } from "@linear/sdk@13.0.0";
+import { LinearClient } from "@linear/sdk";If the goal is hard-pinning, pin the dependency itself ("@linear/sdk": "13.0.0") instead of altering the import specifier.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import { LinearClient } from "@linear/sdk@13.0.0"; | |
| import { LinearClient } from "@linear/sdk"; |
🤖 Prompt for AI Agents
In components/linear_app/linear_app.app.mjs at line 1, the import statement uses
an invalid specifier '@linear/sdk@13.0.0' which Node and bundlers treat as a
single package name and will fail to resolve. Change the import to just
'@linear/sdk' without the version suffix, and ensure the version is pinned in
package.json dependencies instead.
|
@andrewjschuang Heads up that Linear's SDK is WAY ahead of the version you pinned. Try using something solid and stable like the recent version: ^44.1.0
|
|
This was supposed to be a hot fix for another issue. Guess it's better to revert first and then address in a separate place. I'll do this right now, apologize for the inconvenience |
Thanks @andrewjschuang! We saw that other issue occasionally too. If you consider pinning to |
|
I wonder if that will work though, I think it doesn't support that syntax when you import the |
|
Blocked on linear/linear#830. Having issues publishing the component. |
|
@ttrushin I republished the Linear components, I had to use the latest version because of the pinning issues. Gladly the Linear team fixed it very quickly |
WHY
The Linear API key components were getting this error:
SyntaxError
The requested module '@linear/sdk' does not provide an export named 'LinearClient'
Summary by CodeRabbit