-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSP Solo Migration - 9/2/2024, 7:40 PM #15057
Comments
That appears to be a generic GitHub help line, not a Pipedream-specific one. |
This is Pipedream's issue cards. What is BSP Solo Migration? |
Looks more like helpline for Firebase on their firebase-admin-node GItHub repository. User flagged issue in the wrong repo, imo. (if this is a mistake feel free to reopen) |
Reopened, having second thoughts. Let's await user for further input. |
Indeed, as clearly shown in the aforementioned Firebase admin issue (2778),
they have already fixed it in a new version and what Pipedream needs to do
is update to that version, which the previous commit in the other issue did
not do at all. The only reason it would be an issue for Firebase is if the
Node SDK specifically is not yet available in that version.
…On Mon, Dec 23, 2024 at 3:35 PM sergio-eliot-rodriguez < ***@***.***> wrote:
Reopened #15057 <#15057>.
—
Reply to this email directly, view it on GitHub
<#15057 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOBNL7ZSJTGDIUFD524JRD2HCM3TAVCNFSM6AAAAABUBHBEOSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG42TEMZXGM2DAOA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I understand now. cc @malexanderlim revisit of #15033 As of "BSP Solo Micrgration" you are doing some migration on a software called BSP Solo which like needs to use Firebase Admin SDK. |
Unsure if you tried this: from @andrewjschuang 's input in the 15033
|
This isn't a migration anymore per se. It's an already-running integration
that broke with the regression.
…On Mon, Dec 23, 2024 at 3:46 PM sergio-eliot-rodriguez < ***@***.***> wrote:
I understand now.
So the stracktrace says PD is using 13.0.0 of the Firebase Admin SDK.
Now, PD should update its Firabse related components to use a newer
Firebase Admin SDK such that includes the fix.
Ok, so I'll leave it open.
cc @malexanderlim <https://github.com/malexanderlim> revisit of #15033
<#15033>
As of "BSP Solo Micrgration" you are doing some migration on a software
called BSP Solo which like needs to use Firebase Admin SDK.
—
Reply to this email directly, view it on GitHub
<#15057 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOBNLZJT6HZNB4CHLH7N2D2HCOGVAVCNFSM6AAAAABUBHBEOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGQZTQOBTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This is not a trigger action. We shouldn't need to update the code itself
unless doing so clears some cache. I can't attempt that remedy until later
today or tomorrow in any case.
…On Mon, Dec 23, 2024 at 3:48 PM sergio-eliot-rodriguez < ***@***.***> wrote:
Unsure if you tried this: from @andrewjschuang
<https://github.com/andrewjschuang> 's input in the 15033
@WindowsUser <https://github.com/WindowsUser> just to make sure, did you
update the action? If it's a trigger, you'd have to create a new one.
Could you share what is the component name and version? You should see
that info in the Details section of the component while in the workflow
inspector
—
Reply to this email directly, view it on GitHub
<#15057 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOBNLY2KQGKWYXP4LMPZWT2HCOLPAVCNFSM6AAAAABUBHBEOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGQZTSNJSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@WindowsUser I updated the Firebase version here: #15062 Can you remove and re-add the trigger, or update the action and let me know if it works for you now? |
This looks more like what we're looking for. I'll see if I can try tonight
(being out of town means limited laptop access).
…On Mon, Dec 23, 2024 at 3:50 PM Michael Lim ***@***.***> wrote:
@WindowsUser <https://github.com/WindowsUser> I updated the Firebase
version here: #15062 <#15062>
Can you remove and re-add the trigger, or update the action and let me
know if it works for you now?
—
Reply to this email directly, view it on GitHub
<#15057 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOBNLYHXHLQMA3TUCN75KL2HCOT7AVCNFSM6AAAAABUBHBEOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGQ2DAOBSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Unfortunately, it did not work. I tried creating a new trigger but the step still uses version 13.0.0 and (thus, likely) returns the same exact error when I do "run now". |
As for component version, I think this is what you're referring to:
|
I was able to locate your workflow using the deployment version you shared, thanks. Looks like it needed a new updated deployment. @WindowsUser could you please try again now? |
Confirming the issue is resolved, but for future reference, I thought I did redeploy. I guess it did not go through properly because it did not update the version. |
App
BSP Solo Migration - 9/2/2024, 7:40 PM
Summary:
Still Not Fixed: Outdated Firebase Admin SDK
Details:
The previous issue, #15033, did not get fixed by the PR's and commits that purported to do so. We still get this every day:
`
Error
Credential implementation provided to initializeApp() via the "credential" property failed to fetch a valid Google OAuth2 access token with the following error: "The incoming JSON object does not contain a client_email field".
Details
As said before, this is us being affected by firebase/firebase-admin-node#2778 and we know it is still this issue because the version in the file paths is still 13.0.0. Again, this needs to be fixed with priority.
Screenshots:
No screenshots included
The text was updated successfully, but these errors were encountered: