Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tiup-publisher): update tiup-publisher chart #176

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Oct 8, 2024

This pull request includes updates to the charts/tiup-publisher to reflect new versions and simplify the deployment configuration. The most important changes include updating the chart and application versions, and removing unnecessary liveness and readiness probes.

Version updates:

Deployment configuration simplification:

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind October 8, 2024 13:52
Copy link

ti-chi-bot bot commented Oct 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:

  • The version of the chart has been updated from 0.1.0 to 0.2.0.
  • The app version has been updated from v0.1.0 to v20240228-83-g645b571.
  • The liveness and readiness probes have been removed from the deployment.yaml template.

Potential problems:

  • Removing the liveness and readiness probes from the deployment.yaml template may cause issues with the availability and reliability of the application.

Fixing suggestions:

  • Consider adding new liveness and readiness probes to the deployment.yaml template to ensure that the application is available and reliable.
  • If the removal of the liveness and readiness probes was intentional, consider adding a comment explaining the reasoning behind the decision.

@ti-chi-bot ti-chi-bot bot added the size/S label Oct 8, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Oct 8, 2024

/approve

Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit f37a206 into main Oct 8, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the feature/release-tiup-publisher-chart branch October 8, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant