Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update pd start cmd args #1790

Merged
merged 1 commit into from
Feb 15, 2023
Merged

fix: update pd start cmd args #1790

merged 1 commit into from
Feb 15, 2023

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Feb 15, 2023 •
edited
Loading

fix pd error, releated to tikv/pd#5971

glorv
glorv approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glorv, purelind
Once this PR has been reviewed and has the lgtm label, please assign wuhuizuo for approval by writing /assign @wuhuizuo in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@purelind purelind merged commit 881ae98 into main Feb 15, 2023
@purelind purelind deleted the purelind-patch-1 branch February 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@jayl1e jayl1e Awaiting requested review from jayl1e

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purelind @ti-chi-bot @glorv