Remove duplicate entry in TypesWithUndefinedEquality#SPARSE_ARRAY

[rickie]

While there:

• Remove duplicate entry of TypesWithUndefinedEquality#SPARSE_ARRAY
• Sort the enum
• Sort the values of the enum

When opening the PR, add the following comment (open to suggestions):

Should we add java.lang.Object to the TypesWithUndefinedEquality enum?

[rickie]

To make things easier for them to review, ideally, we do something like we did here.

Perhaps @Stephan202 you have an idea on this?

The best I got was this:

comm -3 <(git show origin/master:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java | awk '{$1=$1};1' | sort) <(git show origin/rossendrijver/object_undefined_equality:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java | awk '{$1=$1};1' | sort )

With the somewhat confusing output 😄 :

"android.util.SparseArray",
"androidx.collection.LongSparseArrayCompat"),
	"androidx.collection.LongSparseArrayCompat",
"androidx.collection.SparseArrayCompat"),
"androidx.collection.SparseArrayCompat",
	"androidx.core.util.LongSparseArrayCompat"),
"androidx.core.util.LongSparseArrayCompat",
	DATE("Date", "java.util.Date"),
DATE("Date", "java.util.Date");
	ITERABLE("Iterable", "com.google.common.collect.FluentIterable", "java.lang.Iterable"),
ITERABLE("Iterable", "java.lang.Iterable", "com.google.common.collect.FluentIterable"),
"SparseArray",
SPARSE_ARRAY(
	SPARSE_ARRAY("SparseArray", "android.util.SparseArray", "androidx.collection.SparseArrayCompat");

[Stephan202]

Rebased and added a commit. The following (hacky, likely Linux-only) script verifies that this PR does not introduce additional changes:

#!/usr/bin/env bash

set -e -u -o pipefail

normalize() {
  local rev="${1}"

  git show "${rev}:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java" \
    | grep -Pzo '(?<=LONG_SPARSE_ARRAY\()[^)]+' | grep -Pao '[\w.]+' | sort -u
  git show "${rev}:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java" \
    | grep -Pzo '(?<=SPARSE_ARRAY\()[^)]+' | grep -Pao '[\w.]+' | sort -u
  git show "${rev}:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java" \
    | grep -Po '[A-Z_]+\(' | sort -u
}

diff -u <(normalize master) <(normalize HEAD)

Suggested commit message:

Remove duplicate `TypesWithUndefinedEquality#SPARSE_ARRAY` entry

Type `androidx.collection.SparseArrayCompat` was listed twice.

While there, sort the enum elements and type names.

[Stephan202]

C comes before M 👀

[rickie]

OK rebased it and squash some of the commits. Shall I open the PR with the suggested commit message as description and add a comment as suggested in the PR description?

Also, the script should be in the PR description then 😄 ?

[Stephan202]

I'd open the PR with just the suggested commit message as text, and then add the script as a comment, I think :)

As for adding a comment about Object: yep, SGTM!

[rickie]

Opened PR upstream: google#3110

[rickie]

Fixed in: google@f35b9df.