Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have ThrowsCheckedException also consider supertypes #914

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 10, 2023

Suggested commit message:

Have `ThrowsCheckedException` also consider supertypes (#914)

This prevents the `MonoFromSupplier` Refaster rule from suggesting
noncompilable code.

@Stephan202 Stephan202 added this to the 0.15.0 milestone Dec 10, 2023
Copy link

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 23
class surviving killed
🧟tech.picnic.errorprone.refaster.matchers.ThrowsCheckedException 1 23

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/fix-ThrowsCheckedException branch from 68a5d88 to 6a51169 Compare December 18, 2023 16:53
Copy link

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 23
class surviving killed
🧟tech.picnic.errorprone.refaster.matchers.ThrowsCheckedException 1 23

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one only got fully clear again after playing around with the debugger 😄. Nice improvement :).

" }",
"",
" void positive2() {",
" // BUG: Diagnostic contains:",
" callableSink(getClass()::getDeclaredConstructor);",
" callableSink((Callable<?> & Iterable<?>) null);",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh cool stuff 😄, don't see this often haha.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out to me 👍

This prevents the `MonoFromSupplier` Refaster rule from suggesting
non-compilable code.
@Stephan202 Stephan202 force-pushed the sschroevers/fix-ThrowsCheckedException branch from 6a51169 to ae2ce48 Compare January 1, 2024 11:18
Copy link

github-actions bot commented Jan 1, 2024

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 23
class surviving killed
🧟tech.picnic.errorprone.refaster.matchers.ThrowsCheckedException 1 23

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

sonarqubecloud bot commented Jan 1, 2024

@Stephan202 Stephan202 merged commit 0440df8 into master Jan 1, 2024
16 checks passed
@Stephan202 Stephan202 deleted the sschroevers/fix-ThrowsCheckedException branch January 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants