Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend StepVerifierLastStepVerifyErrorClass Refaster rule #813

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

Venorcis
Copy link
Contributor

@Venorcis Venorcis commented Oct 6, 2023

Added verifyErrorMatches(clazz::isInstance) as a variant of verifyErrorSatisfies(t -> assertThat(t).isInstanceOf(clazz)) that we already rewrite.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Venorcis 😄 !

Suggested commit message:

Extend `StepVerifierLastStepVerifyErrorClass` Refaster rule (#813)

@rickie rickie added this to the 0.15.0 milestone Oct 6, 2023
@Stephan202 Stephan202 force-pushed the vkoeman/verify-error-matches branch from fb12e16 to 16fda27 Compare October 7, 2023 07:22
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a tiny commit. This'll work well together with #811 :).

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit ffe4db2 into master Oct 8, 2023
17 checks passed
@rickie rickie deleted the vkoeman/verify-error-matches branch October 8, 2023 14:22
@Stephan202 Stephan202 changed the title Add another variant to the StepVerifierLastStepVerifyErrorClass Extend StepVerifierLastStepVerifyErrorClass Refaster rule Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants