Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FluxTake Refaster rule for Reactor 3.5.0+ #1128

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 9, 2024

Something I noticed while going over the internal code base.

Suggested commit message:

Update `FluxTake` Refaster rule for Reactor 3.5.0+ (#1128)

@Stephan202 Stephan202 added this to the 0.17.0 milestone Apr 9, 2024
@Stephan202 Stephan202 requested review from werli and rickie April 9, 2024 09:20
Copy link

github-actions bot commented Apr 9, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@werli werli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change assumes users use Reactor 3.5.0+ but I think that's a fair assumption. 👍

Let's roll with it. 🚀

@rickie rickie force-pushed the sschroevers/swap-flux-take-advice branch from 96d9c55 to 9150595 Compare April 16, 2024 14:55
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit 4558f8a into master Apr 16, 2024
15 checks passed
@rickie rickie deleted the sschroevers/swap-flux-take-advice branch April 16, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants