Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update urdf mesh filenames to use package path instead of file find, for general remote usage of rviz #50

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

panagelak
Copy link
Contributor

Hello!

I have a use case that the driver is running on the robot (inside a docker) , and i monitor the robot in rviz from my laptop.

I noticed that when using file://$(find robotiq_description) instead of package://robotiq_description the workspaces on the two computers need to have the same absolute path in order for rviz to show the meshes properly, this pr solves this issue.

Thanks

Copy link
Contributor

@chancecardona chancecardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! The find in file should resolve to a workable version either way I would think, but maybe xacro is doing something weird here with the abs path.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.03%. Comparing base (743d20f) to head (0af8a32).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #50       +/-   ##
==========================================
+ Coverage   0.00%   40.03%   +40.03%     
==========================================
  Files          5       20       +15     
  Lines        352      527      +175     
  Branches       0       33       +33     
==========================================
+ Hits           0      211      +211     
+ Misses       352      311       -41     
- Partials       0        5        +5     
Flag Coverage Δ
unittests 40.03% <ø> (+40.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chancecardona chancecardona merged commit 77e6092 into PickNikRobotics:main Oct 18, 2024
11 checks passed
chancecardona added a commit that referenced this pull request Oct 19, 2024
Co-authored-by: Chance Cardona <41308677+chancecardona@users.noreply.github.com>
chancecardona added a commit that referenced this pull request Oct 19, 2024
Co-authored-by: Chance Cardona <41308677+chancecardona@users.noreply.github.com>
pac48 pushed a commit that referenced this pull request Oct 19, 2024
Co-authored-by: Panagiotis Angelakis <panagelak12@gmail.com>
@sea-bass
Copy link
Contributor

sea-bass commented Dec 19, 2024

FYI this PR seems to have broken Gazebo workflows. Raising an issue now.

EDIT: Resolved by setting the correct GZ_SIM_RESOURCE_PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants