Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

Add commented out Dockerfile commands for installing Nvidia drivers #361

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add commented out Dockerfile commands for installing Nvidia drivers #361

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d855da0
Add placeholder filer for example Dockerfile with nvidia drivers
nbbrooks Sep 3, 2024
678cb66
Add instructions to Dockerfile for manual Nvidia driver installation …
nbbrooks Sep 3, 2024
8e97234
Update Dockerfile
nbbrooks Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
/home/${USERNAME}/.ros && \
chown -R $USER_UID:$USER_GID /home/${USERNAME} /opt/overlay_ws/

# IMPORTANT: Optionally install Nvidia drivers for improved simulator performance with Nvidia GPUs.
# To do this you must
# 1. Uncomment the ENV and RUN entries below
# 2. Replace the 'nvidia-driver-555' apt package with the Nvidia driver version on your host, e.g. nvidia-driver-535, nvidia-driver-555. Use nvidia-smi on your host to determine the driver version.
# After rebuilding via `moveit_pro build` verify the drivers are active in your container by running `nvidia_smi` inside of `moveit_pro shell`.
# ENV DEBIAN_FRONTEND=noninteractive
# RUN apt update && apt install -y software-properties-common
Comment on lines +57 to +58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these two things already done?

Copy link
Member Author

@nbbrooks nbbrooks Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...I do see them in the moveit_studio/Dockerfile (isn't that what FROM ${MOVEIT_STUDIO_BASE_IMAGE} AS base is referencing?)

BUT, yesterday I removed the ENV DEBIAN_FRONTEND=noninteractive to see what would happen and it seemed to be waiting for user input while installing the drivers about keyboard language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENV DEBIAN_FRONTEND=noninteractive
Chat GPT is telling me ARGs are not inherited from the base image, which would be consistent with my experience.

RUN apt update && apt install -y software-properties-common
I think software-properties-common should be installed by the base image. But I think verifying it here should be really fast so I'd prefer to keep it in case someone needs to copy paste this hack into a diff Dockerfile where that might not be true.

Copy link
Member

@EzraBrooks EzraBrooks Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chat GPT is telling me ARGs are not inherited from the base image, which would be consistent with my experience.

yeah but it's an ENV, not an ARG. ChatGPT is lying to you as usual ;)

We only set this to noninteractive once in the entire upstream multistage Dockerfile and it inherits all the way through.

but if you want to leave it here for copy pasta, ok

# RUN add-apt-repository ppa:graphics-drivers/ppa && apt update && apt upgrade -y && apt install -y nvidia-driver-555
nbbrooks marked this conversation as resolved.
Show resolved Hide resolved
nbbrooks marked this conversation as resolved.
Show resolved Hide resolved

# Install additional dependencies
# You can also add any necessary apt-get install, pip install, etc. commands at this point.
# NOTE: The /opt/overlay_ws folder contains MoveIt Pro binary packages and the source file.
Expand Down
Loading