fix -Wall and -Werror errors

PickNikRobotics · Nov 19, 2024 · 9b3af91 · 9b3af91
1 parent 95740e8
commit 9b3af91
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/data_tamer_cpp/3rdparty/mcap/include/mcap/internal.hpp b/data_tamer_cpp/3rdparty/mcap/include/mcap/internal.hpp
@@ -69,7 +69,7 @@ inline const std::string CompressionString(Compression compression) {
 }
 
 inline uint16_t ParseUint16(const std::byte* data) {
-  return uint16_t(data[0]) | (uint16_t(data[1]) << 8);
+  return uint16_t(data[0]) | uint16_t(uint16_t(data[1]) << 8);
 }
 
 inline uint32_t ParseUint32(const std::byte* data) {

diff --git a/data_tamer_cpp/include/data_tamer/channel.hpp b/data_tamer_cpp/include/data_tamer/channel.hpp
@@ -251,7 +251,7 @@ inline void LogChannel::updateTypeRegistry()
     auto func = [this, &fields](const char* field_name, const auto* member) {
       using MemberType =
           typename std::remove_cv_t<std::remove_reference_t<decltype(*member)>>;
-      updateTypeRegistryImpl<MemberType>(fields, field_name);
+      this->updateTypeRegistryImpl<MemberType>(fields, field_name);
     };
     T dummy;
     TypeDefinition(dummy, func);

diff --git a/data_tamer_cpp/include/data_tamer/custom_types.hpp b/data_tamer_cpp/include/data_tamer/custom_types.hpp
@@ -202,7 +202,6 @@ inline CustomSerializer::Ptr TypesRegistry::getSerializer()
                                                                 "as template type");
 
   std::scoped_lock lk(_mutex);
-  T dummy;
   const std::string type_name(CustomTypeName<T>::get());
   auto it = _types.find(type_name);