Move to protobuf for the webapp, major overhaul to easyinstall.sh, code comment translations #229

rdmark · 2021-09-05T01:59:01Z

Implemented RaSCSI commands using protobuf in rascsi-web, removing the dependency on parsing results from rasctl

…port

This reverts commit 210abc7.

This reverts commit 35302ad.

…to determine whether rascsi is running (should hardly be required anymore due to the other change, but just in case).

rdmark · 2021-09-05T23:29:40Z

@akuker @erichelgeson @uweseimet This is ready for testing now.
The major changes in behavior are:

Webapp will throw a 404 if rascsi doesn't respond to the socket connection, e.g. if it is not running. As such, AFAICT there's no longer the 'red' state where the webapp is still operating despite rascsi being unavailable. I don't think this is a huge loss since the webapp is pretty useless without rascsi...
Much more information shown about each attached device. It might be information overload, so I'm thinking in a future revision to have something like a 'details' button that displays a hidden layer with more info, or expands the table, or something like that.
More detailed / different error messages, since they're coming from the protobuf response rather than stdout/stderr
Showing rascsi version number at the bottom (in addition to git revision)
Tiny UI changes to match the functionality of uweseimet_develop

…anslated cfilesystem.cpp

…to feature_webapp_protobuf

rdmark · 2021-09-15T02:02:34Z

src/raspberrypi/devices/cfilesystem.h

-判定が困難なデバイス(自作USBストレージとか)のための保険用。
+Normal is 0. Becomes 1 if attempting to mount in read-only mode.
+Reserving the other values for future use.
+Insurance against hard-to-detect devices such as automatic USB storage.


error in my own translation. Should say "homemade USB storage"

rdmark mentioned this pull request Sep 5, 2021

Web interface should use protobuf interface and not depend on rasctl #144

Closed

rdmark and others added 26 commits September 4, 2021 22:11

Making saving and loading config files work with protobuf

79691a6

Formatted the Status column, and fixed the available ID logic

9e259c9

Updated handling of removed status for devices without image file sup…

db6a5a0

…port

Comment update

8266d7f

Fixed typo

594976e

Updated logging

e628bf9

Merge branch 'akuker:uweseimet_develop' into uweseimet_develop

269a64b

Updated handling of removed status for devices without image file sup…

2e0f1fc

…port

Comment update

22d478d

Fixed typo

0245ca0

Updated logging

733fb99

Better handling of device status

2360815

Updated parameter handling

35302ad

Updated setting default interfaces

210abc7

Revert "Updated setting default interfaces"

8e206bb

This reverts commit 210abc7.

Revert "Updated parameter handling"

d644733

This reverts commit 35302ad.

Abort with a 404 if rascsi is not running. Use any protobuf response …

9312838

…to determine whether rascsi is running (should hardly be required anymore due to the other change, but just in case).

Move id reservation back into __main__

a7a9215

Remove check for device type when validating Removed image

cd2c6a5

Merge branch 'akuker:uweseimet_develop' into uweseimet_develop

f6a294a

Merge branch 'uweseimet_develop' into feature_webapp_protobuf

31c2594

Leverage device property data for better status messages

5d24014

Remove redundant string sanitation when reading config csv file

263a679

Clean up device list generation

6c0836e

Cleanup

f538dd3

Remove duplicates before building valid scsi id list

58b7e33

rdmark marked this pull request as ready for review September 5, 2021 23:20

Fully translated cfilesystem.h code comments to English; partially tr…

9479224

…anslated cfilesystem.cpp

rdmark added 3 commits September 13, 2021 11:16

Merge branch 'akuker:uweseimet_develop' into uweseimet_develop

214480c

Use kwargs for device attachment

2e7682f

Merge branch 'uweseimet_develop' into feature_webapp_protobuf

3d78c02

stinkerton18 mentioned this pull request Sep 13, 2021

The RaSCSI logs do not have entries for disk image creation/deletion #235

Closed

rdmark and others added 6 commits September 13, 2021 14:18

Fix bugs in attach_image kwargs; make config file more readable

b530043

POC for attaching device with profile

c65ef2d

Only list product types valid for the particular image file

7420628

Perform validation of HDD image size based on the product profile

fdba689

Implement sidecar config files for drive images.

3d71677

Added missing product name to NEC vital product data

ecdd966

sonique6784 approved these changes Sep 14, 2021

View reviewed changes

uweseimet and others added 10 commits September 14, 2021 16:48

MO block size depends on capacity only

0136971

Merge branch 'akuker:uweseimet_develop' into uweseimet_develop

8c69c0d

Merge branch 'uweseimet_develop' into feature_webapp_protobuf

11ccf1f

Better error handling for device sidecar config loading

cc0a22c

Extended property/status display

4fe9033

Property display update

70da9c2

Updated error handling

308f750

Handle image sizes in bytes internally

ee5b0b8

Merge branch 'akuker:uweseimet_develop' into uweseimet_develop

1fca73a

Merge branch 'uweseimet_develop' into feature_webapp_protobuf

c38558a

rdmark changed the base branch from uweseimet_develop to develop September 15, 2021 01:32

rdmark added 3 commits September 14, 2021 18:44

Merge branch 'develop' into feature_webapp_protobuf

32cd75e

Revert change

dc5cbe3

Merge branch 'feature_webapp_protobuf' of github.com:rdmark/RASCSI in…

09d0a8e

…to feature_webapp_protobuf

rdmark commented Sep 15, 2021

View reviewed changes

akuker self-requested a review September 15, 2021 02:06

Resolve bad merge

a3f4c82

akuker approved these changes Sep 15, 2021

View reviewed changes

akuker merged commit 8a3642b into PiSCSI:develop Sep 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to protobuf for the webapp, major overhaul to easyinstall.sh, code comment translations #229

Move to protobuf for the webapp, major overhaul to easyinstall.sh, code comment translations #229

rdmark commented Sep 5, 2021

rdmark commented Sep 5, 2021

rdmark Sep 15, 2021

Move to protobuf for the webapp, major overhaul to easyinstall.sh, code comment translations #229

Move to protobuf for the webapp, major overhaul to easyinstall.sh, code comment translations #229

Conversation

rdmark commented Sep 5, 2021

rdmark commented Sep 5, 2021

rdmark Sep 15, 2021

Choose a reason for hiding this comment