Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fundamentally refactor the analytics tests #204

Open
fxjung opened this issue May 13, 2022 · 1 comment
Open

Fundamentally refactor the analytics tests #204

fxjung opened this issue May 13, 2022 · 1 comment
Assignees
@fxjung

Comments

@fxjung
Copy link
Member

fxjung commented May 13, 2022

Most of the analytics suite testing is done by a single, almost 1000 line test that is completely unwieldy and impossible to maintain in the long term. This needs to be split up into the essential parts that are of utmost importance, and other parts, that are not so much. In general, the more project-specific analytics code should move to ridepy-extras, along with the corresponding test code.
@fxjung fxjung self-assigned this May 13, 2022
@fxjung
Copy link
Member Author

fxjung commented May 13, 2022

Not to mention that part of the get_vehicle_quantities functionality is actually broken (or was, I don't remember), which was "checked" by the test. This proves that the current testing scheme does not work.

fxjung added a commit that referenced this issue May 13, 2022
@fxjung
fixed the analytics test for now, still needs heavy refactoring, see #…
3eed861 
…204
fxjung added a commit that referenced this issue May 30, 2022
@fxjung
* commented broken parts
1a16316 
* some analytics things, graph distance cache size increased

* added external cost, renamed class to cls/lower cased some things

* fixed some bugs

* more analytics stuff

* formatting

* fixed analytics bug where the avg stoplist length was computed incorrectly, and cython continuous space bug, where the coord_range was not pickled

* seat capacity and idling duration

* non-analytics tests fixed

* fixed the analytics test for now, still needs heavy refactoring, see #204

* comment removed

* added old file from other branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxjung fxjung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fxjung