Add Charuco Support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Throw a Java doc on this method that says what to do if you wanna ignore a corner, otherwise lgtm |
mcm001
requested changes
May 4, 2024
mcm001
reviewed
May 4, 2024
Comment on lines
84
to
85
| // Assume that we're correct in terms of row/column major-ness (lol) | ||
| for (int c = 0; c < corners.length; c++) { |
There was a problem hiding this comment.
you check you have the same number of snapshots in the board corners and levels arrays, but you never check the length of levels/corners? you should assert that both are equal to rows times height
mcm001
reviewed
May 4, 2024
| var corners = board.toArray(); | ||
| // Assume that we're correct in terms of row/column major-ness (lol) | ||
| for (int c = 0; c < corners.length; c++) { | ||
| if (corners.length != levels.length) { |
There was a problem hiding this comment.
or wait you check the length here, but never that the length is actually correct? we should do that. And why check -inside- the for loop?
mcm001
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.