Undistort using mrcal #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My main open question here is, do the core intrinsics (fx/fy/cx/cy) mean the same thing between models? Like is what I'm doing actually valid? The mrcal page says that u is calculated differently between splined-stereo and pinhole cameras, so it doesn't seem exactly right. But cv::solvepnp should just go do the opposite of my projection step even if the core intrinsics aren't exactly "right", so maybe it doesn't matter? |
mcm001
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undistort from an arbitrary mrcal cameramodel into a normalized pinhole camera with the same focal length and optical center as the input