Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix biometric lock issue on devices running Android 10 or 9 #173

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Fix biometric lock issue on devices running Android 10 or 9 #173

merged 3 commits into from
Dec 23, 2024

Conversation

PranshulGG
Copy link
Contributor

@PranshulGG PranshulGG commented Dec 23, 2024 •
edited by PhilKes
Loading

Fixes #168

Please let me know if there are any issues or areas for improvement. :)

PhilKes
PhilKes requested changes Dec 23, 2024
View reviewed changes
Copy link
Owner

@PhilKes PhilKes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment about the if clause, looks good to me :)

app/src/main/java/com/philkes/notallyx/utils/security/LockUtils.kt Outdated Show resolved Hide resolved
PranshulGG
PranshulGG commented Dec 23, 2024
View reviewed changes
Copy link
Contributor Author

@PranshulGG PranshulGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the redundant if condition inside the when block, as it was unnecessary.

PranshulGG
PranshulGG commented Dec 23, 2024
View reviewed changes
Copy link
Contributor Author

@PranshulGG PranshulGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed setNegativeButton

PhilKes
PhilKes approved these changes Dec 23, 2024
View reviewed changes
Copy link
Owner

@PhilKes PhilKes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@PhilKes PhilKes merged commit 4529e3f into PhilKes:main Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilKes PhilKes PhilKes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes when enabling biometric lock
2 participants
@PranshulGG @PhilKes