Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a crash issue and update sdk version #5376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

waertf
Copy link

@waertf waertf commented Feb 2, 2023

PR Checklist:

  • [o ] I have tested this extensively and it does not break any existing behavior.
  • [ o] I have added/updated examples and tests for any new behavior.
  • [ o] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Fix null pointer exception in draw markers after real time highlighted chart disappear
update compileSdkVersion to 33 and gradle version to 7.2
add MPChartLib binary release
update read me setup for Lib binary Setup

…d chart disappear

update compileSdkVersion to 33 and gradle version to 7.2
fix the issue that cannot build
add MPChartLib binary release
update read me setup for Lib binary Setup
@waertf waertf changed the title fix some crash issues and update sdk version fix a crash issues and update sdk version Feb 2, 2023
@waertf waertf changed the title fix a crash issues and update sdk version fix a crash issue and update sdk version Feb 2, 2023
hannesa2 added a commit to AppDevNext/AndroidChart that referenced this pull request Feb 2, 2023
Cahnges are from PhilJay#5376
hannesa2 added a commit to AppDevNext/AndroidChart that referenced this pull request Feb 2, 2023
Changes are from PhilJay#5376
Copy link
Contributor

@hannesa2 hannesa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use most interesting parts in AppDevNext#100 because the other changes are mostly already applied in my fork.

@waertf
Copy link
Author

waertf commented Feb 2, 2023

reformat as hannesa2 suggested

@hannesa2
Copy link
Contributor

merged in AppDevNext#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants