Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add radar layer custom color support #5273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

penkzhou
Copy link

@penkzhou penkzhou commented Mar 3, 2022

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

before the pr, radar chart cannot custom the chart layer background, like this:
Screenshot_20220303_192335

before the pr, radar chart can custom the chart layer background by a new api, like this:
Screenshot_20220303_192240

radar chart can custom the chart layer background by a new api

reference by this:https://stackoverflow.com/questions/71331675/how-to-fill-color-layer-yaxis-in-mpandroidchart-radar-chart/

<option name="SKIP_ACTIVITY_VALIDATION" value="false" />
<method v="2">
<option name="Android.Gradle.BeforeRunTask" enabled="true" />
</method>
</configuration>
</component>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a extra empty line to address the warning, thanks.

hannesa2 pushed a commit to AppDevNext/AndroidChart that referenced this pull request Mar 7, 2022
hannesa2 pushed a commit to AppDevNext/AndroidChart that referenced this pull request Mar 7, 2022
if (mChart.isCustomLayerColorEnable()) {
temp.set(innerArea);
if (!innerArea.isEmpty()) {
boolean result = innerArea.op(previousPath, Path.Op.DIFFERENCE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes with this lint error
image

image

I solved and merged it in my updated and maintained fork

hannesa2 pushed a commit to AppDevNext/AndroidChart that referenced this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants