Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RMRK Core User/Internal Functions #19

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

HashWarlock
Copy link

Refactor User facing functions to emit Event in the internal functions and move permissions logic to the user facing functions.

Question:

  • Should we move the Lock check to internal function or user facing function (Current solution uses first point)
    • Keeping them in user facing functions allows for downstream implementations to avoid adhering to a Lock during migrations and for custom pallet calls in the runtime to make changes that can bypass the lock
    • Putting them in the internal functions requires all downstream implementations to adhere to this logic and could cause complications for downstream

Copy link

@h4x3rotab h4x3rotab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h4x3rotab h4x3rotab merged commit b6ee87a into polkadot-v0.9.28 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants