-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Polkadot 0.9.27 #916
Conversation
8a7ad0a
to
58f410f
Compare
running 9 tests |
base64 = { version = "0.11", default-features = false, features = ["alloc"] } | ||
phala-types = { path = "../../crates/phala-types", default-features = false } | ||
# v0.4.20+ force required js_sys on WASM target which break runtime (nostd), so we have to pin v0.4.19 | ||
chrono = { version = "=0.4.19", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you reported the issue to chrono?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet, I'll do later, it took me a workday to figure out why runtime failed to compile
34bb9a2
to
3679d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we can merge the #913 into this branch.
sure, then I'll avoid to use force push |
@kvinwang maybe you need to help to take a look this |
It's OK. |
pink: Only use the lower 16bit of the chain extension id
Though CI is green, but there's a failed on ARM64 macOS
I made this test only run on x86_64 Linux target |
paritytech/substrate@polkadot-v0.9.26...polkadot-v0.9.27
Overall, Substrate are not change too much, but some crates minimal version up lead incompatible
Notable changes:
chrono
tov0.4.19
cause above version force requirejs_sys
which break runtimeink
to3.3.1
to compatible with latest Substrate