Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Polkadot 0.9.27 #916

Merged
merged 8 commits into from
Aug 12, 2022
Merged

Upgrade to Polkadot 0.9.27 #916

merged 8 commits into from
Aug 12, 2022

Conversation

jasl
Copy link
Collaborator

@jasl jasl commented Aug 9, 2022

paritytech/substrate@polkadot-v0.9.26...polkadot-v0.9.27

Overall, Substrate are not change too much, but some crates minimal version up lead incompatible

Notable changes:

  • Pin Phala pallet chrono to v0.4.19 cause above version force require js_sys which break runtime
  • Upgrade some crates
  • Upgrade ink to 3.3.1 to compatible with latest Substrate
  • Rocket switch back to official GitHub, kevin's patch merged with small changes (the maintainer said)

@jasl jasl force-pushed the polkadot-v0.9.27 branch 4 times, most recently from 8a7ad0a to 58f410f Compare August 11, 2022 21:54
@jasl
Copy link
Collaborator Author

jasl commented Aug 12, 2022

running 9 tests
test test_load_contract_file ... ok
[2022-08-12T00:06:53Z ERROR pink] [5DTN3gDHB5fuJcNDgm8v5ezd1RhQHwx3wxqJsy8st9G1TGdb] initialized
test test_use_cache ... ok
[2022-08-12T00:06:53Z ERROR pink] [5DTN3gDHB5fuJcNDgm8v5ezd1RhQHwx3wxqJsy8st9G1TGdb] a test message received
test test_logging ... ok
test test_start_sidevm ... ok
test test_signing ... ok
test test_ink_flip ... ok
test test_ink_cross_contract_instanciate ... ok
test test_on_block_end ... ok
test test_mq_egress ... ok

@jasl jasl force-pushed the polkadot-v0.9.27 branch from 58f410f to daa2f7c Compare August 12, 2022 00:07
@jasl jasl marked this pull request as ready for review August 12, 2022 00:07
@jasl jasl requested a review from kvinwang August 12, 2022 00:08
base64 = { version = "0.11", default-features = false, features = ["alloc"] }
phala-types = { path = "../../crates/phala-types", default-features = false }
# v0.4.20+ force required js_sys on WASM target which break runtime (nostd), so we have to pin v0.4.19
chrono = { version = "=0.4.19", default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you reported the issue to chrono?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, I'll do later, it took me a workday to figure out why runtime failed to compile

@jasl jasl force-pushed the polkadot-v0.9.27 branch 2 times, most recently from 34bb9a2 to 3679d9c Compare August 12, 2022 08:35
@jasl jasl force-pushed the polkadot-v0.9.27 branch from 3679d9c to 7516ee3 Compare August 12, 2022 08:38
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can merge the #913 into this branch.

@jasl
Copy link
Collaborator Author

jasl commented Aug 12, 2022

LGTM. I think we can merge the #913 into this branch.

sure, then I'll avoid to use force push

@jasl
Copy link
Collaborator Author

jasl commented Aug 12, 2022

running 9 tests test test_load_contract_file ... ok [2022-08-12T00:06:53Z ERROR pink] [5DTN3gDHB5fuJcNDgm8v5ezd1RhQHwx3wxqJsy8st9G1TGdb] initialized test test_use_cache ... ok [2022-08-12T00:06:53Z ERROR pink] [5DTN3gDHB5fuJcNDgm8v5ezd1RhQHwx3wxqJsy8st9G1TGdb] a test message received test test_logging ... ok test test_start_sidevm ... ok test test_signing ... ok test test_ink_flip ... ok test test_ink_cross_contract_instanciate ... ok test test_on_block_end ... ok test test_mq_egress ... ok

@kvinwang maybe you need to help to take a look this

@kvinwang
Copy link
Collaborator

@kvinwang maybe you need to help to take a look this

It's OK.

jasl added 2 commits August 12, 2022 17:11
pink: Only use the lower 16bit of the chain extension id
@jasl
Copy link
Collaborator Author

jasl commented Aug 12, 2022

Though CI is green, but there's a failed on ARM64 macOS

     Running unittests src/lib.rs (target/debug/deps/pink_sidevm_macro-ab8b44cea7fc0a1c)

running 2 tests
Error: file `/dev/fd/0` does not exist
test tests::test_ocall ... FAILED
test tests::test_main ... ok

failures:

---- tests::test_ocall stdout ----
thread 'tests::test_ocall' panicked at 'called `Option::unwrap()` on a `None` value', crates/rustfmt-snippet/src/lib.rs:30:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::test_ocall

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.16s

I made this test only run on x86_64 Linux target
cc @kvinwang

@jasl jasl enabled auto-merge August 12, 2022 13:55
@jasl jasl merged commit 00745a8 into master Aug 12, 2022
@jasl jasl deleted the polkadot-v0.9.27 branch August 12, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants