Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to download PNG type photos #1

Closed
revanorion opened this issue Dec 18, 2022 · 2 comments
Closed

Fails to download PNG type photos #1

revanorion opened this issue Dec 18, 2022 · 2 comments

Comments

@revanorion
Copy link

Seems like PNG files are not being downloaded correctly from the twitter image server. The resulting file is a 0 byte PNG file in the output.

A 404 is returned when the downloader appends ?format=jpg&name=orig to the tweet image url for PNGs, however JPGs work correctly. Removing this appended query string to the url fixes the issue and both PNG and JPGs are downloaded correctly.

Example:
https://pbs.twimg.com/media/FdiUS2_WYAA43bR.png
https://pbs.twimg.com/media/FdiUS2_WYAA43bR.png?format=jpg&name=orig

PetrusZ added a commit that referenced this issue Jan 5, 2023
@PetrusZ PetrusZ closed this as completed in 338290e Jan 5, 2023
@PetrusZ
Copy link
Owner

PetrusZ commented Jan 5, 2023

Sorry for the late reply, don't know why I missed this issue before. It should be fixed now, can you test it?

@revanorion
Copy link
Author

Yup all fixed now. Thanks and great tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants