Move EnumVariantsNames into a trait which the macro implements #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iantNames macro implements
Peternator7
requested changes
Nov 17, 2019
Peternator7
approved these changes
Nov 24, 2019
|
Looks good! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a case where I had to accept a generic parameter of any enum type that has the
variants()function implemented, which would've previously required some awkward workarounds. This PR moves the function into its own traitVariantNamesand changes theEnumVariantNamesto implement it, so that it is possible to use the trait to accept any such enum (see the added test case).