regcomp(_internal)?.c: Avoid some casts in prints #23728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
reviewed
Sep 19, 2025
khwilliamson
force-pushed
the
no_print_casts
branch
from
33edab8 to
3ca8d66
Compare
tonycoz
reviewed
Sep 22, 2025
tonycoz
reviewed
Sep 22, 2025
We have modifiers like %z and %t to portably print items of the given type. This converts to use those in these files, removing casts that were previously used.
khwilliamson
force-pushed
the
no_print_casts
branch
from
3ca8d66 to
2234112
Compare
|
From the second commit message:
should that be "but the intention ..."? |
This converts from using IV to UV. Code points are currently restricted to 0..IV_MAX, but the intention is to eventually use values outside that range for internal purposes. This avoids any potential issues with printing an IV in hex format
khwilliamson
force-pushed
the
no_print_casts
branch
from
2234112 to
92f0b7a
Compare
|
yes, fixed |
tonycoz
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have modifiers like %z and %t to portably print items of the given type. This converts to use those in these files, removing casts that were previously used.