Fix g++ build (Add extra scope block for switch case) #20109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in 9fdd7fc broke the g++ builds,
Basically after the commit the code looked like:
g++ does not allow this and errors with:
This happens because
rhs
andlval
are not scoped in the case statementso it could fall through to the next case.
The solution is to scope them which this commit now does by adding a
separate scope for
OP_SASSIGN
(similar toOP_AASSIGN
).Fixes #20108