Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After running an action in the debugger, turn it off #17901

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

choroba
Copy link
Contributor

@choroba choroba commented Jun 26, 2020

When running with "c", there was no problem, but when running with "n"
or "s", once the action was executed, it kept executing on the
following lines, which wasn't expected. Clearing $action here prevents
this unwanted behaviour.

@choroba
Copy link
Contributor Author

choroba commented Jul 18, 2020

Squashed and rebased. Please merge or comment.

@tonycoz
Copy link
Contributor

tonycoz commented Jul 27, 2020

Is there any chance you could write a test for this? (in lib/perl5db.t)

@choroba
Copy link
Contributor Author

choroba commented Jul 27, 2020

Test force pushed.

@choroba
Copy link
Contributor Author

choroba commented Jul 27, 2020

Another commit included - #10034 was in fact a sub-bug of this, the fix for it is no longer needed.

@tonycoz
Copy link
Contributor

tonycoz commented Jul 28, 2020

Thanks, I'll fix the test failures when this is merged (somehow perl5db.pl was made executable).

When running with "c", there was no problem, but when running with "n"
or "s", once the action was executed, it kept executing on the
following lines, which wasn't expected. Clearing $action here prevents
this unwanted behaviour.
as it's cleared right after it's been run.
@choroba
Copy link
Contributor Author

choroba commented Jul 28, 2020

If you mean the perl5db.t, it was my fault (default editor setting). Should be fixed now.

@tonycoz
Copy link
Contributor

tonycoz commented Jul 29, 2020

Thanks, I'll merge this once blead opens (which should be soon)

@khwilliamson khwilliamson merged commit 589464a into Perl:blead Jul 30, 2020
toddr added a commit that referenced this pull request Jul 30, 2020
@choroba choroba deleted the db-action branch July 31, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants