gh17730: regcomp overflow/underflow #17744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
requested changes
Apr 23, 2020
Ah bother, I thought I'd fixed that already. |
The dubious '((*ACCEPT)0)*' construct resulted on the one hand with is_inf being false, but on the other setting pos_delta to OPTIMIZE_INFTY.
Numeric underflow on max_offset was being silently converted to OPTIMIZE_INFTY by a misleading test. That test was removed in f6231eb, exposing multiple issues. This restores the test in a more direct form for 5.32; it should be removed after 5.32 is released so we can continue the search for the underlying issues.
xsawyerx
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid overflow when setting last_start_max; add temporary underflow guard in scan_commit.