Change WORKDIR from / to /usr/src/app #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed is that in bookworm the lib dir has become a symlink to /usr/lib. This prevents `COPY . .` to copy over our lib dir to the layer. For more information: * https://wiki.debian.org/NewInBookworm * https://wiki.debian.org/UsrMerge * https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978636: Closes: Perl#140 Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
|
LGTM, thanks @waterkip ! 🙏 Can we add a test in https://github.com/Perl/docker-perl/blob/master/.github/workflows/build-image.yml based on what we've observed (so on the off chance we revert |
Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
waterkip
force-pushed
the
GL-140-docker_workdir
branch
from
df73e8c
to
641f1c2
Compare
|
Added the test. It might be considered a breaking change. For example, if someone did |
zakame
approved these changes
Aug 3, 2023
Haha, ok ok :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed is that in bookworm the lib dir has become a symlink to /usr/lib.
This prevents
COPY . .to copy over our lib dir to the layer.For more information:
Closes: #140
Signed-off-by: Wesley Schwengle waterkip@cpan.org