Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to Align with Latest Module Exports #85

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

lanvent
Copy link
Contributor

@lanvent lanvent commented Sep 3, 2023

Description:

This PR updates the usage examples in the README.md to match the latest version of exported variables in the repository.

Notes:

Firstly, I want to extend my deepest gratitude for creating such a phenomenal tool. I've experimented with multiple JS deobfuscation utilities, and this one outshines them all by a large margin. It literally saved my day! The customizability is also a fantastic feature. After going through some documents on the espree library and your repository code, I was able to achieve even more specific needs.

Secondly, I have a minor suggestion. The following code snippet in the library:

// Silence asyc errors
process.on('uncaughtException', () => {});

While I understand that the intent is to silence asynchronous errors, this also suppresses all exceptions. It made debugging a bit challenging for me as I am not deeply familiar with JavaScript. It might be helpful to add an option or warning for this behavior and some guidance on error logging.

Thank you for considering these changes, and for the incredible tool you've created.

@BenBaryoPX BenBaryoPX self-requested a review September 4, 2023 06:14
@BenBaryoPX BenBaryoPX merged commit 8dcd9d8 into PerimeterX:main Sep 4, 2023
@BenBaryoPX
Copy link
Collaborator

BenBaryoPX commented Sep 4, 2023

Thanks for the kind words and for taking the time to align the readme!
As for your suggestion, that's a good one. I still want to keep this behavior by default, but I'll add a method to remove the event listener. I've opened an issue for it so it can be tracked - #86 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants