Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some flows #83

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fixed some flows #83

merged 1 commit into from
Apr 19, 2023

Conversation

wbaccinelli
Copy link
Contributor

No description provided.

@wbaccinelli wbaccinelli requested a review from bscheltinga April 19, 2023 11:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@@ -167,38 +107,10 @@ nlu:
examples: |
- "EXTERNAL_rescheduling_preparation_phase"

- intent: relapse_dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need an intent for this dialog as it is user triggered as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the help_intent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahaha I just figured out and wanted to say that :)

@@ -1,7 +1,6 @@
version: "3.1"

intents:
- relapse_dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be: 'EXTERNAL_relapse_dialog'

And use this external also in the action instead of:

celery.send_task('celery_tasks.user_trigger_dialog', (user_id, Components.RELAPSE_DIALOG))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, this line has been deleted

@wbaccinelli wbaccinelli merged commit cfed171 into main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants