319 closing dialog #75
Conversation
|
I do have a specific question on the top 5 of the first aid kit. I think there is a bug and it shows not the top 5 in terms of rating, but the top 5 entries from the db. I looked into it but cannot find what's going wrong. So it is printing:
However, in the database, this is the rating from low to high. The highest rated activity is not printed. |
This got fixed in the latest commit. Function 'get_faik_text' is added to to .helper, this function is called in faik and closing dialog actions. |
| - EXTERNAL_delayed_message_smoke_lapse | ||
| - EXTERNAL_delayed_message_smoke |
There was a problem hiding this comment.
Do these two intents work even if they are not defined in the nlu?
There was a problem hiding this comment.
Yes, it did work!
| closing_pf_grade: | ||
| type: text | ||
| influence_conversation: false | ||
| mappings: | ||
| - type: from_text | ||
| conditions: | ||
| - active_loop: closing_evaluate_pf_form | ||
| requested_slot: closing_pf_grade | ||
|
|
||
| closing_pf_evaluate: | ||
| type: text | ||
| influence_conversation: false | ||
| mappings: | ||
| - type: from_text | ||
| conditions: | ||
| - active_loop: closing_evaluate_pf_form | ||
| requested_slot: closing_pf_evaluate |
There was a problem hiding this comment.
Why has the requested_slot to be specified?
There was a problem hiding this comment.
Requested slot needs to be specified if one form is used to fill multiple slots. Otherwise, the first slot is discarded if the second form is filled...
| if value not in ['Klaar', 'klaar']: | ||
| return {"closing_relapse_prevention_plan_one_done": None} |
There was a problem hiding this comment.
Definitely we can use the validator
| if value not in ['Klaar', 'klaar']: | ||
| return {"closing_relapse_prevention_plan_two_done": None} |
|
|
||
| async def run(self, dispatcher, tracker, domain): | ||
| user_id = int(tracker.current_state()['sender_id']) # retrieve userID | ||
| new_intent = 'EXTERNAL_delayed_message_smoke_lapse' |
There was a problem hiding this comment.
Let's move the definition to the ComponentsTriggers class in the definitions in the DB.
| new_intent = 'EXTERNAL_delayed_message_smoke_lapse' | |
| new_intent = ComponentsTriggers.DELAYED_MSG_LAPSE |
|
|
||
| async def run(self, dispatcher, tracker, domain): | ||
| user_id = int(tracker.current_state()['sender_id']) # retrieve userID | ||
| new_intent = 'EXTERNAL_delayed_message_smoke' |
There was a problem hiding this comment.
| new_intent = 'EXTERNAL_delayed_message_smoke' | |
| new_intent = ComponentsTriggers.DELAYED_MSG_SMOKE |
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
…rtual-coach-rasa into 319-closing-dialog
|
SonarCloud Quality Gate failed. |
Fixes: PerfectFit-project/virtual-coach-issues#319