-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
364 adapt text notification #104
Conversation
I changed rasa domain files based on suggestions in the testing ticket (PerfectFit-project/testing-tickets#13). Therefore, it is now deviating from the excel files we have in teams (for C1.29, C1.27 and C1.26) How did we do that so far? Did we also change the excel files on team in that case? I think the content and phrasing should be matching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just removed some spaces at the end because I always find those confusing when writing tests.
And yes, I agree that we should update the changes in the excel files on Teams. Maybe not in red (because that suggests that the changes are not incorporated yet) though, but some other color.
Also, good catch that the alternative formulations were not there yet.
Lastly, I don't know if there are any tests with these notifications, but if yes, would be good to update those too.
Co-authored-by: Nele Albers <43779515+nelealbers@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed!
|
Thanks @nelealbers, I updated the excel filesl |
Fixes: PerfectFit-project/testing-tickets#13
Fixes: PerfectFit-project/virtual-coach-issues#364