Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiPartUpload.get_all_parts return 1,000 multipart uploads max #162

Merged
merged 1 commit into from
May 31, 2017
Merged

MultiPartUpload.get_all_parts return 1,000 multipart uploads max #162

merged 1 commit into from
May 31, 2017

Conversation

islue
Copy link
Contributor

@islue islue commented May 30, 2017

No description provided.

timvaillancourt
timvaillancourt reviewed May 30, 2017
View reviewed changes
mongodb_consistent_backup/Upload/S3/S3.py Outdated
@@ -1,6 +1,7 @@
import os
import logging

import boto
Copy link
Contributor

@timvaillancourt timvaillancourt May 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to import less of boto here? @islue

Example:

import boto.s3.multipart

Copy link
Contributor

@timvaillancourt timvaillancourt May 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also let's put the import on line #1 so 'import's are in alphabetical order, if possible.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 says to put imports from the standard library at the top, and imports from third party packages underneath as islue has done.

Copy link
Contributor

@timvaillancourt timvaillancourt May 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @rob256. My suggestion is to import boto.s3.multipart only, then.

timvaillancourt
timvaillancourt suggested changes May 30, 2017
View reviewed changes
Copy link
Contributor

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see comment about 'import boto'

@islue
Copy link
Contributor Author

islue commented May 31, 2017

My pleasure to fix the import issue.
I intended to use force push to merge the tiny fix but also removed reviews. Sorry for that, I'll be careful next time.

@timvaillancourt
Copy link
Contributor

Thanks @islue, this looks good!

@timvaillancourt timvaillancourt merged commit 49f9a88 into Percona-Lab:master May 31, 2017
@timvaillancourt timvaillancourt mentioned this pull request May 31, 2017
Merged
@islue islue deleted the s3_multipart branch June 2, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob256 rob256 rob256 left review comments

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@islue @timvaillancourt @rob256