Replace console errors with configuration warnings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of pushing an error to the console every time that an input cannot be found in the InputMap, we can add it to the ActionPrompt's configuration warnings instead. This reduces the amount of console output and makes it clearer where the issue lies. Closes #6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pushing an error to the console every time that an input cannot be found in the InputMap, we can add it to the ActionPrompt's configuration warnings instead.
This reduces the amount of console output and makes it clearer where the issue lies.
Closes #6.
@betalars, could you please test this and let me know if you agree that it addresses the issue you raised in #6?