Fix Mistake in convert_fO2_to_fe_partition #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Mistake and updated for readibility
|
Hi Felix, I independently was working on a bug fix for this. I cant follow exactly what you changed as a lot of the changes are just entering of new lines which is making it super hard to follow. I'm hoping my fix is the same as your fix? But let me know if not. I also added some more buffers. |
|
Hi Penny, The issue was on line 4172. The code references 'logfo2_offset' which doesn't exist. It should be 'fo2_offset' instead. Doesn't look like that's changed as of today. Felix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed reference to 'logfo2_offset', which should read 'fo2_offset' around line 4172.
Updated formatting to improve readability