Remove input arg control wires of MultiControlledX
#6832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6832 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 476 476
Lines 45183 45177 -6
==========================================
- Hits 45006 45000 -6
Misses 177 177 ☔ View full report in Codecov by Sentry. |
JerryChen97
changed the title
control wires of multi controlled xcontrol wires of multi controlled x
JerryChen97
changed the title
control wires of multi controlled xcontrol wires of multi controlled x
astralcai
approved these changes
Jan 15, 2025
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
JerryChen97
commented
Jan 15, 2025
|
Spotted deprecated usages in lightning https://github.com/PennyLaneAI/pennylane-lightning/pull/1040/files |
JerryChen97
added
the
do not merge ⚠️
|
Another open PR from qml used deprecated interface, although it seems long time unmaintained. PennyLaneAI/qml#386 (comment) |
JerryChen97
changed the title
control wires of multi controlled xcontrol wires of MultiControlledX
|
Lightning fix merged. We set this removal as auto-merge now. |
JerryChen97
added
merge-ready ✔️
JerryChen97
deleted the
Remove-init-arg-`control_wires`-of-MultiControlledX
branch
joeycarter
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Jan 20, 2025
**Context:** The input argument `control_wires` was recently removed from [`qml.MultiControlledX`](https://docs.pennylane.ai/en/stable/code/api/pennylane.MultiControlledX.html) in PennyLaneAI/pennylane#6832. This API change resulted in a failure in the Catalyst test `TestGateAliases.test_control_aliases` in the "Check CPL latest/latest/latest" workflow. For reference, the call signature of `qml.MultiControlledX` changed from ```python qml.MultiControlledX(control_wires, wires, control_values, work_wires) ``` to ```python qml.MultiControlledX(wires, control_values, work_wires) ``` **Description of the Change:** Update the failing test to use the new call signature of `qml.MultiControlledX`. Also, prefer to explicitly pass in the wire index or list of wire indices by keyword argument with `wires=...`, rather than as positional arguments, to hopefully avoid similar issues in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Years ago we deprecated some features inside
MultiControlledXbut they were forgotten for a while, among which we have the argumentcontrol_wiresto remove today.Description of the Change:
Remove the input
control_wiresalong with testsBenefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81795]