Make BasisRotation jit compatible
#6779
Merged
+13
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.40.0-rc0 #6779 +/- ##
==============================================
Coverage ? 99.60%
==============================================
Files ? 476
Lines ? 45222
Branches ? 0
==============================================
Hits ? 45045
Misses ? 177
Partials ? 0 ☔ View full report in Codecov by Sentry. |
andrijapau
reviewed
Jan 8, 2025
andrijapau
reviewed
Jan 8, 2025
astralcai
approved these changes
Jan 8, 2025
obliviateandsurrender
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
PR #6019 only fixes
BasisRotationwhen using backprop ondefault.qubit. It is not jit compatible on any other device. This is becauseunitary_matrixwas being considered a hyperparameter, not a piece of data. So we could not detect that the matrix was a tracer and we were in jitting mode, and we could not convert the matrix back into numpy data.Description of the Change:
Make
unitary_matrixa piece of data instead of a hyperparameter. This allows us to detect when it is being jitted.As a by-product, I also made it valid pytree.
By making
unitary_matrixa piece of data, we were able to get rid of the custom comparison method inqml.equal.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-51603] Fixes #6004