Fix postselection Nan sampling with different environment setups #6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic update of stable requirement files to snapshot valid python environments. Because bots are not able to trigger CI on their own, please do so by pushing an empty commit to this branch using the following command: ``` git commit --allow-empty -m 'trigger ci' ``` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christina Lee <christina@xanadu.ai>
Created automatically from the `pennylane_version_bump.sh` script. - **Remove rc0 from version number** - **Changes to set up 0.41.0 dev branch** --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
andrijapau
approved these changes
Jan 7, 2025
Co-authored-by: Andrija Paurevic <46359773+andrijapau@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.40.0-rc0 #6777 +/- ##
==============================================
Coverage ? 99.60%
==============================================
Files ? 476
Lines ? 45232
Branches ? 0
==============================================
Hits ? 45055
Misses ? 177
Partials ? 0 ☔ View full report in Codecov by Sentry. |
lillian542
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When running tests locally, I was getting failures like:
We had logic to catch the error
'probabilities contain NaN', but something about my versioning gives a slightly different capitalization. To prevent this happening of other people, I updated the error catching to be capitalization independent.Description of the Change:
Catch both
"Probabilities contain NaN"and"probabilities contain NaN".Benefits:
Tests pass locally for my environment.
Possible Drawbacks:
Still a bit error prone. I'm also not sure what about my environment gives different capitalization.
Related GitHub Issues: