Multiplier Operators Quantum Arithmetic #6112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
soranjh
reviewed
Aug 19, 2024
gmlejarza
changed the title
gmlejarza
changed the title
KetpuntoG
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Nice, it's looking good!
In the tests remember to apply the changes requested in qml.Adder as well:
- merge
test_operation_result_args_Nonewith the previous test. - remove comment from
jax.jit - import auxiliary function from file
Remember also to include the templates in the __init__ file so we can call them as qml.Multiplier directly.
KetpuntoG
reviewed
Aug 23, 2024
KetpuntoG
reviewed
Aug 23, 2024
…AI/pennylane into multipliers_arithmetic
soranjh
approved these changes
Aug 23, 2024
mudit2812
pushed a commit
that referenced
this pull request
Sep 10, 2024
### Before submitting
- [ ] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
------------------------------------------------------------------------------------------------------------
**Context:**
Adding Multiplier templates for Quantum Arithmetic.
**Description of the Change:**
Adding Multiplier and OutMultiplier templates to perform arithmetic
operations between quantum registers.
**Benefits:**
Users can implement arithmetic operations in an easy and efficient way.
**Related GitHub Issues:** [sc-71592]
---------
Co-authored-by: KetpuntoG <65235481+KetpuntoG@users.noreply.github.com>
Co-authored-by: soranjh <soran.jahangiri@gmail.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
Context:
Adding Multiplier templates for Quantum Arithmetic.
Description of the Change:
Adding Multiplier and OutMultiplier templates to perform arithmetic operations between quantum registers.
Benefits:
Users can implement arithmetic operations in an easy and efficient way.
Related GitHub Issues: [sc-71592]