Add Lattice class and transverse-field Ising Hamiltonian #6106

ddhawan11 · 2024-08-15T17:14:13Z

Context:
Add spin Hamiltonian functions to PennyLane.

Description of the Change:
Adds a new class to generate lattice object, which is further used to generate spin Hamiltonians.

Benefits:
Users can easily generate spin Hamiltonians.

[sc-70982]

codecov · 2024-08-15T17:40:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (1f55c88) to head (ad9dc4c).
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6106      +/-   ##
==========================================
- Coverage   99.67%   99.65%   -0.02%     
==========================================
  Files         432      435       +3     
  Lines       41839    41845       +6     
==========================================
- Hits        41702    41701       -1     
- Misses        137      144       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

soranjh

Thanks @ddhawan11, left some preliminary comments.

pennylane/spin/__init__.py

pennylane/spin/lattice.py

tests/spin/test_lattice.py

tests/spin/test_lattice_shapes.py

tests/spin/test_spin_hamiltonian.py

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

pennylane/spin/spin_hamiltonian.py

ddhawan11 · 2024-08-19T16:41:45Z

[sc-70982]

obliviateandsurrender

Good work @ddhawan11! Leaving the first set of comments.

pennylane/spin/__init__.py

pennylane/spin/lattice.py

pennylane/spin/lattice_shapes.py

pennylane/spin/spin_hamiltonian.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

pennylane/spin/lattice.py

tests/spin/test_spin_hamiltonian.py

pennylane/spin/spin_hamiltonian.py

tests/spin/test_lattice.py

pennylane/spin/lattice.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

pennylane/spin/lattice.py

pennylane/spin/spin_hamiltonian.py

tests/spin/test_lattice.py

pennylane/spin/lattice.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

obliviateandsurrender

Given that CI passes all the checks and @soranjh will be satisfied with the docs, should be good to go from my end!

soranjh

Thanks @ddhawan11, looks good to go. Just pushed some minor doc fixes and added a few final comments and questions.

pennylane/spin/lattice.py

pennylane/spin/spin_hamiltonian.py

tests/spin/test_lattice.py

tests/spin/test_spin_hamiltonian.py

soranjh

Thanks @ddhawan11, looks good to me.

**Context:** Add spin Hamiltonian functions to PennyLane. **Description of the Change:** Adds a new class to generate lattice object, which is further used to generate spin Hamiltonians. **Benefits:** Users can easily generate spin Hamiltonians. [sc-70982] --------- Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> Co-authored-by: Utkarsh <utkarshazad98@gmail.com> Co-authored-by: soranjh <soran.jahangiri@gmail.com>

ddhawan11 added 2 commits August 15, 2024 12:24

Lattice class and template spin Hamiltonians

703d1fb

Docstring formatting

da3af95

ddhawan11 requested a review from soranjh August 15, 2024 17:14

ddhawan11 added 2 commits August 16, 2024 11:34

Shortened the PR and added more tests

847273e

Cleaned up some

1df7f0c

soranjh reviewed Aug 19, 2024

View reviewed changes

soranjh requested a review from obliviateandsurrender August 19, 2024 16:24

ddhawan11 and others added 2 commits August 19, 2024 12:28

Update pennylane/spin/__init__.py

42b994a

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/lattice.py

dbdb677

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

soranjh reviewed Aug 19, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 changed the title ~~[WIP] Add Spin hamiltonians~~ Add Lattice class and transverse-field Ising Hamiltonian Aug 19, 2024

obliviateandsurrender requested changes Aug 19, 2024

View reviewed changes

ddhawan11 and others added 7 commits August 20, 2024 07:07

Update pennylane/spin/__init__.py

b139df7

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/lattice.py

d42e6ed

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/lattice.py

d6df727

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

dcee93b

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

[skip ci] Addressed reviews

981c0fb

[skip ci] updated change-log

932b823

Merge branch 'master' into spin_hamiltonian

2fe07b2

ddhawan11 marked this pull request as ready for review August 20, 2024 17:17

ddhawan11 requested review from soranjh and obliviateandsurrender August 20, 2024 17:20

[skip ci] Fixed a test

7bae9d2

obliviateandsurrender requested changes Aug 20, 2024

View reviewed changes

ddhawan11 and others added 4 commits August 21, 2024 02:48

Update pennylane/spin/lattice.py

b89147d

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

91fde16

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

196fca2

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

104a3b8

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

ddhawan11 and others added 10 commits August 21, 2024 02:49

Update pennylane/spin/lattice.py

d0541bf

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/lattice.py

a9d6177

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

532d95f

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

768d7cd

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Addressed reviews

a18af1a

vectorized some code

e3aca61

vectorized some code

ac0e960

Increased test coverage

c7260a0

Increased test coverage

6439a47

Addressed review comments

a81fe95

obliviateandsurrender reviewed Aug 21, 2024

View reviewed changes

ddhawan11 and others added 4 commits August 21, 2024 11:30

Update pennylane/spin/lattice.py

6b388a4

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/lattice.py

9b98c45

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

3849ae0

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

[skip ci] addressed comments

856acd0

obliviateandsurrender approved these changes Aug 21, 2024

View reviewed changes

soranjh added 3 commits August 21, 2024 16:09

add minor doc fixes

794d4a1

add minor doc fixes

a3f76db

add minor doc fixes

20d1735

soranjh reviewed Aug 21, 2024

View reviewed changes

tests/spin/test_spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 and others added 4 commits August 22, 2024 07:38

Fixed tests

683bbcd

Merge branch 'master' into spin_hamiltonian

930b4a7

Fixed CI

260c60c

Added more test coverage

bf65324

soranjh approved these changes Aug 22, 2024

View reviewed changes

Minor doc fix

ad9dc4c

ddhawan11 merged commit 3646d80 into master Aug 22, 2024
40 checks passed

ddhawan11 deleted the spin_hamiltonian branch August 22, 2024 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Lattice class and transverse-field Ising Hamiltonian #6106

Add Lattice class and transverse-field Ising Hamiltonian #6106

ddhawan11 commented Aug 15, 2024 •

edited by soranjh

Loading

codecov bot commented Aug 15, 2024 •

edited

Loading

soranjh left a comment

ddhawan11 commented Aug 19, 2024

obliviateandsurrender left a comment

obliviateandsurrender left a comment •

edited

Loading

soranjh left a comment

soranjh left a comment

Add Lattice class and transverse-field Ising Hamiltonian #6106

Add Lattice class and transverse-field Ising Hamiltonian #6106

Conversation

ddhawan11 commented Aug 15, 2024 • edited by soranjh Loading

codecov bot commented Aug 15, 2024 • edited Loading

Codecov Report

soranjh left a comment

Choose a reason for hiding this comment

ddhawan11 commented Aug 19, 2024

obliviateandsurrender left a comment

Choose a reason for hiding this comment

obliviateandsurrender left a comment • edited Loading

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

ddhawan11 commented Aug 15, 2024 •

edited by soranjh

Loading

codecov bot commented Aug 15, 2024 •

edited

Loading

obliviateandsurrender left a comment •

edited

Loading