Make Exp.decomposition jit compatible
#6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh146
reviewed
Aug 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6082 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 430 430
Lines 41836 41548 -288
==========================================
- Hits 41697 41406 -291
- Misses 139 142 +3 ☔ View full report in Codecov by Sentry. |
astralcai
changed the title
Exp.decomposition qjit compatibleExp.decomposition jit compatible
astralcai
commented
Aug 8, 2024
mudit2812
reviewed
Aug 8, 2024
dime10
approved these changes
Aug 9, 2024
mudit2812
approved these changes
Aug 9, 2024
dime10
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Aug 29, 2024
PennyLaneAI/pennylane#6082 unearthed that in an attempt to be more lenient with user supplied types, Catalyst eagerly converts any type to the required float64 type for gate parameters, including when this results in a loss of data (like converting complex numbers to floats). This fixes the issue as well as providing some minor code cleanup, and fixing a long-standing issue of potentially undefined variables in the Python code. In order to help users with the proposed fix in [#pennylane/6082 ](PennyLaneAI/pennylane#6082) for the decomposition of `Exp`, the error message for complex gate parameters mentions potential non-unitary operators like the exponential with real exponent. [sc-71066]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The result of
Exp.decompositiondepends whether the coefficient is purely imaginary or not, which makes it incompatible with qjit.Description of the Change:
ChangeExp.decompositionto queue decomposed operations in a temporary queueing context, and then convert it to a list of operations, making it compatible withqml.condChange
Exp.decompositionto not raise an error when the coefficient is real.Benefits:
Workflows that involve
Expare now compatible withqjitandjax.jitPossible Drawbacks:
This is a very hacky solution.Exp.decompositionis still not compatible withjax.jit.When applying
qml.expon an operator with real coefficients, in a jitted context, no error is thrown.Related GitHub Issues:
Fixes PennyLaneAI/catalyst#923
Also Fixes #5993
[sc-68711]