-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default values to for_loop
#6068
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6068 +/- ##
========================================
Coverage 99.66% 99.66%
========================================
Files 430 430
Lines 41786 41519 -267
========================================
- Hits 41644 41379 -265
+ Misses 142 140 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to approve once we get some more robust testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improved tests. Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end @obliviateandsurrender!
Context: This adds the default
step=1
and arange
-like syntax support for single-parameter.Description of the Change: One can now do the following instead of specifying complete
(0, 3, 1)
:Benefits:
Possible Drawbacks: None
Related GitHub Issues: [sc-70477] [sc-70478]