-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for while_loop
capture
#6064
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6064 +/- ##
========================================
Coverage 99.66% 99.66%
========================================
Files 430 430
Lines 41786 41517 -269
========================================
- Hits 41644 41377 -267
+ Misses 142 140 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together 🎉
Context: This add support for capturing
while_loop
into plxpr.Description of the Change: The function's behaviour resembles the one for
for_loop
, and works on capturing bothcond_fn
andbody_fn
and executing both of them at runtime.Benefits:
while_loop
will enjoyplxpr
when capture is enabledPossible Drawbacks: N/A
Related GitHub Issues: [sc-66773]