Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for while_loop capture #6064

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Conversation

obliviateandsurrender
Copy link
Contributor

Context: This add support for capturing while_loop into plxpr.

Description of the Change: The function's behaviour resembles the one for for_loop, and works on capturing both cond_fn and body_fn and executing both of them at runtime.

Benefits: while_loop will enjoy plxpr when capture is enabled

Possible Drawbacks: N/A

Related GitHub Issues: [sc-66773]

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (4934593) to head (1c68675).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6064    +/-   ##
========================================
  Coverage   99.66%   99.66%            
========================================
  Files         430      430            
  Lines       41786    41517   -269     
========================================
- Hits        41644    41377   -267     
+ Misses        142      140     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812 mudit2812 self-requested a review August 5, 2024 14:50
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together 🎉

@obliviateandsurrender obliviateandsurrender enabled auto-merge (squash) August 8, 2024 14:41
@obliviateandsurrender obliviateandsurrender merged commit bb51b79 into master Aug 8, 2024
40 checks passed
@obliviateandsurrender obliviateandsurrender deleted the capture_while_loop branch August 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants