Add support for multi-controlled zyz #6042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6042 +/- ##
==========================================
- Coverage 99.67% 99.65% -0.02%
==========================================
Files 432 432
Lines 41839 41704 -135
==========================================
- Hits 41702 41562 -140
- Misses 137 142 +5 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Jul 26, 2024
trbromley
reviewed
Jul 26, 2024
5 tasks
trbromley
reviewed
Jul 31, 2024
albi3ro
reviewed
Aug 2, 2024
albi3ro
reviewed
Aug 2, 2024
albi3ro
reviewed
Aug 2, 2024
albi3ro
reviewed
Aug 2, 2024
trbromley
reviewed
Aug 2, 2024
albi3ro
reviewed
Aug 2, 2024
Co-authored-by: Cristian Emiliano Godinez Ramirez <57567043+EmilianoG-byte@users.noreply.github.com>
albi3ro
approved these changes
Aug 20, 2024
EmilianoG-byte
approved these changes
Aug 21, 2024
maliasadi
added a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Aug 22, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
PR PennyLaneAI/pennylane#6042 adds support for
multi-controlled zyz.
For Lightning, this means that custom decompositions to special zyz with
multiple controlled wires will be supported.
**Description of the Change:**
- Add tests for adjoint jacobian of the controlled gate with multiple
controlled_wires.
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-67711]
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
multiphaseCFD
pushed a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Sep 8, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
PR PennyLaneAI/pennylane#6042 adds support for
multi-controlled zyz.
For Lightning, this means that custom decompositions to special zyz with
multiple controlled wires will be supported.
**Description of the Change:**
- Add tests for adjoint jacobian of the controlled gate with multiple
controlled_wires.
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-67711]
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
mudit2812
pushed a commit
that referenced
this pull request
Sep 10, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
This PR implements the decomposition of zyz for special unitaries with
multiple control wires defined in Lemma 7.9 of
https://arxiv.org/pdf/quant-ph/9503016.
**Benefits:**
Support decomposition of zyz for special unitaries.
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-68471]
---------
Co-authored-by: albi3ro <chrissie.c.l@gmail.com>
Co-authored-by: Cristian Emiliano Godinez Ramirez <57567043+EmilianoG-byte@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR implements the decomposition of zyz for special unitaries with multiple control wires defined in Lemma 7.9 of https://arxiv.org/pdf/quant-ph/9503016.
Benefits:
Support decomposition of zyz for special unitaries.
Possible Drawbacks:
Related GitHub Issues:
[sc-68471]