-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for converting Qiskit Noise models #5996
Conversation
…o noise-model-convert
Hello. You may have forgotten to update the changelog!
|
…o noise-model-convert
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5996 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 430 430
Lines 41488 41210 -278
==========================================
- Hits 41348 41069 -279
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @obliviateandsurrender. Just a comment about the confusing example lol, but otherwise it seems like the changes are pretty straightforward. No tests are necessary for this load_noise_model
function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender, please address my final minor points before merging. Also, please make sure that @trbromley and @isaacdevlugt approve the kwargs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender! This looks really nice ⭐. Couple suggestions on docstring wording / explanation. Otherwise, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender! This overall looks great. Once we've resolved my final question there will be no more blockers from me.
Context: Adds support for converting Qiskit noise models to PennyLane ones.
Description of the Change: Adds a
from_qiskit_noise
function that uses implementation inpennylane-qiskit
plugin for executing the conversion.Benefits: Qiskit noise models can be mapped to PL ones.
Possible Drawbacks: Multi-qubit errors would be a bit harder to track since PL only has single-qubit error channels (except
qml.QubitChannel
).Related GitHub Issues: [sc-68046]