Change default value of from_qasm to keep the measurements

[EmilianoG-byte]

Context:

The new default should be to return the QASM measurements (i.e. new default is measurements=None). Users can access the old behaviour by explicitly passing measurements=[], as communicated in the deprecation warning added in 0.37.

Description of the Change:

Default value of from_qasm argument measurements is None.

[sc-66686]

[github-actions]

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

• A one-to-two sentence description of the change. You may include a small working example for new features.
• A link back to this PR.
• Your name (or GitHub username) in the contributors section.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (94b5533) to head (eede54e).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5982      +/-   ##
==========================================
- Coverage   99.66%   99.65%   -0.01%     
==========================================
  Files         427      427              
  Lines       40983    40724     -259     
==========================================
- Hits        40845    40585     -260     
- Misses        138      139       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[isaacdevlugt]

Thanks @EmilianoG-byte! just a couple suggestions and questions. Please tag me again when you're ready 👌

[trbromley]

Thanks @EmilianoG-byte!

[EmilianoG-byte]

@isaacdevlugt @trbromley @lillian542 , done with the changes, lmk what you think!

[trbromley]

Thanks @EmilianoG-byte, this is a great improvement!

[lillian542]

Thanks @EmilianoG-byte, this looks much cleaner and clearer! I left a couple of minor comments :)

[lillian542]

For some reason when I open the docs build on your last commit, it doesn't reflect your most recent changes. I made one more suggestion, maybe see if updating that and triggering CI updates the build?

[lillian542]

Looks good, thanks @EmilianoG-byte! Glad the sphinx issue is resolved 😅

I have one final suggestion (that I think will actually work this time 🙈) for how to make a docstring-compatible version of the qasm_code string that will also work in a notebook. See what you think!

[isaacdevlugt]

Thanks Emiliano! 🚀 This is more clear than before. Thanks for catching this originally!