Change wire repr #5958
Merged
Change wire repr #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-67920] |
|
Tagging @isaacdevlugt for visibility - not sure if this PR is ready to take a look at yet. |
It's ready! It's a very small PR that just addresses the changes that come about with changing the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5958 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 425 425
Lines 40926 40630 -296
==========================================
- Hits 40793 40496 -297
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
soranjh
reviewed
Jul 10, 2024
soranjh
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
To accommodate the implementation of
qml.registers, the_repr_of Wires should be something more copy-paste friendly rather than what it is currentlyDescription of the Change:
The
_repr_of Wires is nowWires([0])rather than<Wires = [0]>Benefits:
Easier to copy and paste
Possible Drawbacks:
Might make docs confusing in other places. Not sure where else <Wires = ...> notation will be found in docs.
Related GitHub Issues: