-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parameter broadcasting with GlobalPhase
#5923
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5923 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 430 430
Lines 41505 41213 -292
========================================
- Hits 41362 41072 -290
+ Misses 143 141 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sorry about missing the part where broadcasting is tested for matrix.
Context:
GlobalPhase
does not support broadcasting yet.Description of the Change:
Introduce broadcasting to
GlobalPhase
, using the code fromPauliRot
withset(pauli_word) == {"I"}
.The latter falls back to the
GlobalPhase
implementation.Also fixes a small bug where the global phase returned by
one_qubit_decomposition
gains a broadcasting dimension even if the input matrix does not have one.Benefits:
Broadcasting support & Bug fix
Unlocks #4460
Possible Drawbacks:
Related GitHub Issues:
Implements #5815
Fixes #5880
[sc-65316]