turn QuantumScript.hash into a cached property #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5919 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 425 425
Lines 40772 40479 -293
==========================================
- Hits 40640 40345 -295
- Misses 132 134 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
dwierichs
approved these changes
Jul 2, 2024
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
lillian542
approved these changes
Jul 2, 2024
RenkeHuang
pushed a commit
to RenkeHuang/pennylane
that referenced
this pull request
Jul 11, 2024
**Context:** When investigating some performance issues, I noticed that we weren't caching `QuantumScript.hash`, even though calculating it is a known performance bottleneck. **Description of the Change:** Make `QuantumScript.hash` a cached property. **Benefits:** Much lower classical overhead when we are using caching. <img width="839" alt="Screenshot 2024-06-28 at 5 38 15 PM" src="https://github.com/PennyLaneAI/pennylane/assets/6364575/9d25401d-af74-455b-8a18-04fc7dc07c33"> **Possible Drawbacks:** If someone does bad things and mutates the tape in place, they will have to deal with the resulting consequences. **Related GitHub Issues:** --------- Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When investigating some performance issues, I noticed that we weren't caching
QuantumScript.hash, even though calculating it is a known performance bottleneck.Description of the Change:
Make
QuantumScript.hasha cached property.Benefits:
Much lower classical overhead when we are using caching.
Possible Drawbacks:
If someone does bad things and mutates the tape in place, they will have to deal with the resulting consequences.
Related GitHub Issues: